Code review verbeteringen en documentatie updates#24
Merged
ericwout-overheid merged 3 commits intomainfrom Feb 19, 2026
Merged
Conversation
- SQL injection preventie: table name validatie in ClickHouseRepository - Connection leak fix: shutdown() sluit ClickHouse client via repository.close() - Veilige cast naar ReadableSpan in LogboekInterceptor (as? i.p.v. as) - Lazy initialisatie van serviceName in ProcessingHandler - Provided scope voor jakarta.ws.rs-api en microprofile-config-api - All-open plugin uitgebreid met @interceptor annotatie - ClickHouse Docker image gepind naar versie 25 - README hernoemd naar JVM, Kotlin voorbeeld toegevoegd - Workflow hernoemd naar "CI with Maven" - Typo fix in ClickHouseSpanExporterTest Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
- shutdown() vangt nu exceptions op en retourneert ofFailure() - Test verificatie toegevoegd voor repository.close() in shutdown - Parameterized tests voor table name validatie - ClickHouse image gepind naar versie 25.3 (LTS) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
De tabelnaam werd bij elke insert en ensureSchema opnieuw uit de config gelezen en gevalideerd. Nu wordt de tabelnaam eenmalig bij constructie opgeslagen en gevalideerd. De table parameter is verwijderd uit insertJsonEachRow en de tableName is verwijderd uit ClickHouseSpanExporter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AmbtenaarInFunctie
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samenvatting
ClickHouseRepositorymet regex patroonshutdown()inClickHouseSpanExportersluit nu de ClickHouse client viarepository.close()ReadableSpancast inLogboekInterceptorgebruikt nuas?i.p.v. onveiligeasserviceNameinProcessingHandlergebruikt nuby lazyom vroegtijdige config loading te voorkomenprovidedscope toegevoegd voorjakarta.ws.rs-apienmicroprofile-config-api@Interceptorannotatie voor CDI proxyingenabledproperty gedocumenteerdClickHouseSpanExporterTestTestplan
mvn testslaagt (37 bestaande tests)🤖 Gegenereerd met Claude Code