Skip to content

Conversation

ymekuria
Copy link

@ymekuria ymekuria commented Sep 2, 2025

Summary

Updates proof-systems submodule reference to include new pointer-based lagrange basis functions that fix zkProgram.compile() hanging in web browsers with cache writing.

Changes

Context

Part of fixing the critical issue where zkProgram.compile() with cache writing (cache.canWrite = true) hangs indefinitely in web browsers due to WasmVector return types not being transferable over web worker API.

Related PRs

This is part 2 of 3 for the complete fix:

  1. proof-systems#3325 (Rust functions)
  2. This PR: mina (submodule reference update)
  3. o1js#2404 (worker spec + TypeScript integration)

Files Changed

  • Updated git submodule reference for src/lib/crypto/proof-systems

@ymekuria ymekuria requested a review from a team as a code owner September 2, 2025 08:33
@ymekuria ymekuria changed the title Update proof-systems submodule for lagrange basis pointer functions Update proof-systems for web cache lagrange basis fix Sep 2, 2025
@glyh
Copy link
Member

glyh commented Sep 2, 2025

I think you could close #17615?

Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve as soon as we review and approve the proof-systems counterpart 👍🏻

Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now, but take into consideration that you will want to bump-up proof-systems to a later commit, once CI is all green (outdated base branch + 2 CI failing jobs)

Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just calling out that with this commit you update proof-systems to the latest commit of master. maybe check with @dannywillems if that's okay. I would prefer if we could split this into multiple atomic PRs given that we've encountered a few issues with bumping proof-systems in the past

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants