Skip to content

Push sig kind out of txn witness #17882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Push sig kind out of txn witness #17882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/snark_work_lib/sub_zkapp_spec.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ let write_all_proofs_to_disk ~(proof_cache_db : Proof_cache_tag.cache_db) :
{ statement
; witness =
Transaction_snark.Zkapp_command_segment.Witness
.write_all_proofs_to_disk ~proof_cache_db witness
.write_all_proofs_to_disk
~signature_kind:Mina_signature_kind.t_DEPRECATED ~proof_cache_db
witness
; spec
}
| Merge { proof1; proof2 } ->
Expand Down
2 changes: 1 addition & 1 deletion src/lib/snark_worker/prod.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ module Impl = struct
} ->
let witness =
Transaction_witness.Zkapp_command_segment_witness
.write_all_proofs_to_disk ~proof_cache_db witness
.write_all_proofs_to_disk ~signature_kind ~proof_cache_db witness
in

let%map proof, elapsed =
Expand Down
3 changes: 1 addition & 2 deletions src/lib/transaction_witness/transaction_witness.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ module Zkapp_command_segment_witness = struct
; block_global_slot
}

let write_all_proofs_to_disk ~proof_cache_db
let write_all_proofs_to_disk ~signature_kind ~proof_cache_db
({ global_first_pass_ledger
; global_second_pass_ledger
; local_state_init
Expand All @@ -117,7 +117,6 @@ module Zkapp_command_segment_witness = struct
; block_global_slot
} :
Stable.V1.t ) : t =
let signature_kind = Mina_signature_kind.t_DEPRECATED in
{ global_first_pass_ledger
; global_second_pass_ledger
; local_state_init =
Expand Down
5 changes: 4 additions & 1 deletion src/lib/transaction_witness/transaction_witness.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ module Zkapp_command_segment_witness : sig
val read_all_proofs_from_disk : t -> Stable.Latest.t

val write_all_proofs_to_disk :
proof_cache_db:Proof_cache_tag.cache_db -> Stable.Latest.t -> t
signature_kind:Mina_signature_kind.t
-> proof_cache_db:Proof_cache_tag.cache_db
-> Stable.Latest.t
-> t
end

[%%versioned:
Expand Down
3 changes: 2 additions & 1 deletion src/lib/work_partitioner/snark_worker_shared.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ module Zkapp_command_inputs = struct

let write_all_proofs_to_disk ~proof_cache_db : Stable.V1.t -> t =
Nonempty_list.map ~f:(fun (witness, segment, stmt) ->
( Zkapp_command_segment.Witness.write_all_proofs_to_disk ~proof_cache_db
( Zkapp_command_segment.Witness.write_all_proofs_to_disk
~signature_kind:Mina_signature_kind.t_DEPRECATED ~proof_cache_db
witness
, segment
, stmt ) )
Expand Down