Skip to content

Conversation

glyh
Copy link
Member

@glyh glyh commented Oct 4, 2025

This logic has been introduced into daemon recently.

[%log info] "Removing lockfile for terminated process"

@glyh glyh requested a review from a team as a code owner October 4, 2025 03:58
@cjjdespres
Copy link
Member

This logic has been introduced into daemon recently.

[%log info] "Removing lockfile for terminated process"

It doesn't seem that recent, judging from the git history. That being said, the line being changed in this PR is also old, and I agree that it seems redundant, since the daemon will clean up the lock file itself.

@glyh
Copy link
Member Author

glyh commented Oct 9, 2025

@SanabriaRusso , could you approve since Christian thinks so? He worked on related context before :)

@SanabriaRusso
Copy link
Member

For keeping track of the issue: I have tested an artifact produced from this PR and still shows the constant restarts issue. I.e., of the lockfile is not removed and the Pod (tested in Kubernetes with persistence, in this case) is killed/restarted, the next instance is unable to start.

@glyh glyh marked this pull request as draft October 13, 2025 11:34
@glyh
Copy link
Member Author

glyh commented Oct 13, 2025

Drafting for now. I think it's another bug we're running into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants