Skip to content

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Oct 7, 2025

Rewrite HF test core logic in Go.

Explain how you tested your changes:

  • Successfully executed new HF test

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee force-pushed the georgeee/hf-test-go branch 2 times, most recently from 69c09d7 to ec89fba Compare October 9, 2025 20:26
@georgeee georgeee force-pushed the georgeee/hf-test-go branch from ec89fba to 9bd5c76 Compare October 9, 2025 20:32
echo "Creates a quick-epoch-turnaround configuration in localnet/ and launches two Mina nodes" >&2
echo "Usage: $0 [-m|--mina $MINA_EXE] [-i|--tx-interval $TX_INTERVAL] [-d|--delay-min $DELAY_MIN] [-s|--slot $SLOT] [--develop] [-c|--config ./config.json] [--slot-tx-end 100] [--slot-chain-end 130] [--genesis-ledger-dir ./genesis]" >&2
echo "Consider reading script's code for information on optional arguments" >&2
usage() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were introduced to make output of the script nicer, not directly related to rewrite to Go

"${NODE_ARGS_1[@]}" \
--block-producer-key "$PWD/$CONF_DIR/bp" \
--config-directory "$PWD/localnet/runtime_1" \
--run-snark-worker "$(cat $CONF_DIR/bp.pub)" --work-selection seq \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix of a pre-existing glitch, not directly related to rewrite to Go

@georgeee georgeee changed the title Hardfork test rewrite prototype Rewrite hardfork test to Go Oct 9, 2025
@georgeee georgeee marked this pull request as ready for review October 9, 2025 20:34
@georgeee georgeee requested review from a team as code owners October 9, 2025 20:34
@georgeee
Copy link
Member Author

georgeee commented Oct 9, 2025

!ci-build-me

@georgeee
Copy link
Member Author

georgeee commented Oct 9, 2025

!ci-nightly-me

@georgeee
Copy link
Member Author

georgeee commented Oct 9, 2025

!ci-bypass-changelog

@glyh
Copy link
Member

glyh commented Oct 13, 2025

That's a lot of code

@glyh
Copy link
Member

glyh commented Oct 13, 2025

@glyh
Copy link
Member

glyh commented Oct 13, 2025

It seems there's issue:

    [ "Sys_error", "/etc/localtime: No such file or directory" ],

we should probably fix this inside our hosted nix image gcr.io/o1labs-192920/nix-unstable:1.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants