-
Notifications
You must be signed in to change notification settings - Fork 583
Rewrite hardfork test to Go #17919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compatible
Are you sure you want to change the base?
Rewrite hardfork test to Go #17919
Conversation
69c09d7
to
ec89fba
Compare
ec89fba
to
9bd5c76
Compare
echo "Creates a quick-epoch-turnaround configuration in localnet/ and launches two Mina nodes" >&2 | ||
echo "Usage: $0 [-m|--mina $MINA_EXE] [-i|--tx-interval $TX_INTERVAL] [-d|--delay-min $DELAY_MIN] [-s|--slot $SLOT] [--develop] [-c|--config ./config.json] [--slot-tx-end 100] [--slot-chain-end 130] [--genesis-ledger-dir ./genesis]" >&2 | ||
echo "Consider reading script's code for information on optional arguments" >&2 | ||
usage() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were introduced to make output of the script nicer, not directly related to rewrite to Go
"${NODE_ARGS_1[@]}" \ | ||
--block-producer-key "$PWD/$CONF_DIR/bp" \ | ||
--config-directory "$PWD/localnet/runtime_1" \ | ||
--run-snark-worker "$(cat $CONF_DIR/bp.pub)" --work-selection seq \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix of a pre-existing glitch, not directly related to rewrite to Go
!ci-build-me |
!ci-nightly-me |
!ci-bypass-changelog |
That's a lot of code |
It seems there's issue:
we should probably fix this inside our hosted nix image |
Rewrite HF test core logic in Go.
Explain how you tested your changes:
Checklist: