Add hard fork genesis delta config parameter #17931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjjdespres
force-pushed
the
cjjdespres/hard-fork-genesis-slot-delta
branch
from
1e7acef to
7136e8e
Compare
|
!ci-build-me |
glyh
approved these changes
Oct 14, 2025
| ; zkapp_cmd_limit_hardcap : int option [@default None] | ||
| ; slot_tx_end : int option [@default None] | ||
| ; slot_chain_end : int option [@default None] | ||
| ; hard_fork_genesis_slot_delta : int option [@default None] |
There was a problem hiding this comment.
Could we add a in-code documentation here indicating the purpose? So people don't have to track back to this PR for this option? Thanks :)
There was a problem hiding this comment.
I have added some documentation.
|
!ci-build-me |
|
Right, this branch is out of date as well. |
The hard_fork_genesis_slot_delta option tracks the slot span between the slot_chain_end and the planned proof.fork.global_slot_since_genesis of an upcoming hard fork. In a future commit it will be incorporated into the hard fork account migration and the root ledger sync mechanism.
cjjdespres
force-pushed
the
cjjdespres/hard-fork-genesis-slot-delta
branch
from
6fbb932 to
2631f26
Compare
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard_fork_genesis_slot_delta option tracks the slot span between the slot_chain_end and the planned proof.fork.global_slot_since_genesis of an upcoming hard fork. In a future commit it will be incorporated into the hard fork account migration and the root ledger sync mechanism.
It can't quite be used in the ledger sync code yet (for the vesting parameter adjustment) because the structure of the ledger root code assumes that the conversion function can be determined at compile time. I'll change the converting merkle tree code (or the root code) slightly to compensate in a later update.