Remove unused Storage_locations ledger component #17933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-bypass-changelog |
|
!ci-build-me |
cjjdespres
force-pushed
the
cjjdespres/remove-unused-storage-location
branch
from
d2a8b8c to
3a21195
Compare
|
!ci-build-me |
The key_value_db_dir is not used anywhere in the code base. Looking at the git history, it seems as though it was superceded by the ~directory_name parameter being added to the create method of the database ledger.
cjjdespres
force-pushed
the
cjjdespres/remove-unused-storage-location
branch
from
3a21195 to
fbf9604
Compare
|
!ci-build-me |
glyh
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storage_locations module and its key_value_db_dir value are not used anywhere in the code base. Looking at the git history, it seems as though they were superceded by the ~directory_name parameter being added to the create method of the database ledger.
The string
"mina_key_value_db"also does not appear in this repo, for what it's worth.