Fix problems with genesis epoch ledgers being equal #17935
+44
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both staking and next epoch ledgers have the same merkle root, reuse the staking ledger tar file instead of generating it twice. This prevents different s3_data_hash values caused by different tar creation timestamps, even though the ledger content is identical.
|
!ci-build-me |
|
!ci-bypass-changelog |
glyh
reviewed
Oct 13, 2025
| Deferred.Or_error.return | ||
| ( Some | ||
| { Consensus.Genesis_epoch_data.Data.ledger = | ||
| staking.ledger |
There was a problem hiding this comment.
I'm a bit concerned about this branch. We never assume ledgers to be shared between 2 "holders", AFAIK. Would there be some mutation/destroy of the ledgers on one end, causing the other end to panic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a test network withjust genesis ledger defined and doing fork config export during the first epoch, exported epoch ledgers (staking and next) will point to the same value and the node will fail to start because of trying to initiate epoch ledger DB from the same directory.
This PR fixes this issue in Mina node, and also ensures that when genesis ledger app generates a config, it won't show different SHA hashes for the same ledger.
Commits:
Explain how you tested your changes:
Checklist: