Skip to content

Conversation

@glyh
Copy link
Member

@glyh glyh commented Nov 17, 2025

As title.

Copy link
Member

@georgeee georgeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we go one step further and clean the directory used for benchmark at the end of each test

In order to do that let's use the same directory for all of the tests without suffixing it with the name. In the initialization code let's check if that directory exists and if it does, let's remove it.

This way we'll ensure that the test can be run if there is enough disk space for just one directory because it's much lighter requirement than having disk space for 8 directories 20 GB each.

So, in the initialization code for each test we'll remove the directory from the previous run if it existed. After all the tests are run (exactly as it is implemented right now), let's clean up the directory that remained after the last test.

@georgeee georgeee added the oom label Nov 17, 2025
@glyh glyh force-pushed the lyh/georgeee/db-bench branch from ce9836e to 0d752a2 Compare November 24, 2025 05:21
@glyh glyh requested a review from georgeee November 24, 2025 05:21
@glyh glyh force-pushed the lyh/georgeee/db-bench branch from 0d752a2 to 5ad9e56 Compare November 24, 2025 05:24
@glyh
Copy link
Member Author

glyh commented Nov 24, 2025

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants