[Europe GCR 1/3] un-hardcode gcr.io repo from various scripts #18125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!ci-build-me |
1 similar comment
Member
Author
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/unhardcode_gcr
branch
from
9fd7042 to
724f911
Compare
Member
Author
|
!ci-build-me |
glyh
reviewed
Nov 18, 2025
scripts/docker/promote.sh
Outdated
| else | ||
| TARGET_REPO=$GCR_REPO | ||
| if [[ -z "$TARGET_REPO" ]]; then | ||
| TARGET_REPO=$REGISTRY |
Member
There was a problem hiding this comment.
In what use case, would TARGET_REPO & REGISTRY be different, may I ask?
Member
Author
There was a problem hiding this comment.
righty, my mistake when splitting PR, good catch
glyh
reviewed
Nov 18, 2025
glyh
reviewed
Nov 18, 2025
| MINA_IMAGE="gcr.io/o1labs-192920/mina-daemon:$MINA_DOCKER_TAG-berkeley" | ||
| ARCHIVE_IMAGE="gcr.io/o1labs-192920/mina-archive:$MINA_DOCKER_TAG-berkeley" | ||
|
|
||
| MINA_IMAGE="$DOCKER_REPO/$MINA_DOCKER_NAME:$MINA_DOCKER_TAG-berkeley" |
Member
There was a problem hiding this comment.
Note for future: I remember berkeley is just devnet with a different genesis? We should probably consider removing berkeley testnet after the HF.
Member
Author
|
!ci-build-me |
glyh
approved these changes
Nov 18, 2025
SanabriaRusso
approved these changes
Nov 18, 2025
Member
|
!ci-bypass-changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is Part of great migration from gcr.io to europe repo for cost optimization. In this, very first step we just want to open up the door for repo changes by exposing paramters which defines docker repositories.