Implement multi-key file storage #18127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a very simple way to store a set of related values in an efficient manner. Values are assumed to written all in one batch. Values can't be updated or deleted individually (the only way possible is to overwrite the whole file or remove the file). Reading of the key reads only the bytes of file that are reuired for the read. It's an efficient way to store data that is semantically connected, written and garbage-collected, but that needs to be accessed piecewise.
Allows to serialize tags without overhead and fragility of storing filenames, using semantically-meaningful representation instead.
georgeee
force-pushed
the
georgeee/multi-key-file-storage
branch
from
a5132e8 to
17c0197
Compare
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-bypass-changelog |
martyall
approved these changes
Nov 18, 2025
Member
There was a problem hiding this comment.
This is pretty clever.
To be honest I didn't really understand how write_values_exn was working until I read the tests because I wasn't registering the importance of universal quantification in write_value.
If I has one suggestion for readability in my case, it would be to use a different type variable in the type definition of write_value and write_values, like use a in write_value and as in write_values
Member
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement multi-key file storage.
Idea was first tested in benchmarks in PR #18117. Idea is to store heavy parts of a block (witnesses, which are part of scan state) in the new file storage, and be able to reference them from all over the codebase, including the ability to store references on disk (for which a
Stablemodule is provided for tags).Explain how you tested your changes:
Checklist: