Skip to content

Support mina advanced generate-hard-fork-config in hf test #18158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
glyh wants to merge 40 commits into
base: compatible
Choose a base branch
from
Draft

Support mina advanced generate-hard-fork-config in hf test #18158

glyh wants to merge 40 commits into from

Conversation

@glyh
Copy link
Member

@glyh glyh commented Nov 24, 2025 •
edited
Loading

Status:

test failing, investigating.

@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch 2 times, most recently from 9ed1c9d to d5f8c81 Compare November 25, 2025 07:36
@glyh glyh mentioned this pull request Nov 25, 2025
Closed
@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch 2 times, most recently from 0382964 to e48f40a Compare November 25, 2025 13:09
@glyh glyh mentioned this pull request Nov 25, 2025
Open
4 tasks
@glyh glyh marked this pull request as ready for review November 25, 2025 13:53
@glyh glyh requested review from a team as code owners November 25, 2025 13:53
@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch 5 times, most recently from 4b385a0 to 89a9062 Compare November 25, 2025 15:34
Base automatically changed from lyh/factor-out-legacy-hf-phase to compatible November 25, 2025 23:40
@glyh glyh marked this pull request as draft November 26, 2025 03:18
@glyh glyh changed the title Support advanced ref fork config mode in hf test Support `mina advanced generate-hard-fork-config in hf test Nov 26, 2025
@glyh glyh changed the title Support `mina advanced generate-hard-fork-config in hf test Support mina advanced generate-hard-fork-config in hf test Nov 26, 2025
@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch from 59a3614 to 24fd19d Compare November 26, 2025 11:27
@mergify mergify bot mentioned this pull request Nov 26, 2025
Closed
@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch 5 times, most recently from 2a37394 to ff4e053 Compare December 2, 2025 03:53
@mergify mergify bot mentioned this pull request Dec 2, 2025
Closed
@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch 4 times, most recently from 1736e3d to 142720b Compare December 2, 2025 08:14
glyh added 29 commits December 3, 2025 14:50
@glyh
document the purpose & usage of scripts/hardfork/create_runtime_confi…
88fedd9 
…g.sh
@glyh
hardfork test > ledger.go: document GenerateForkConfigAndLedgers
cddb13a
@glyh
make create-runtime-config.sh syntax stricter
6427263
@glyh
hardfork > create_runtime_config.sh: improve jq expression readability
522673c
@glyh
hardfork test: implement a script that's designed specifically to pat…
10bd587 
…ch on config generated by `mina advanced generate-hard-fork-config`
@glyh
hardfork test: implement advanced fork procedure
c593ec4
@glyh
hardfork test: wire advanced fork phase
7d5234a
@glyh
hardfork test: allow advanced fork method to be used in hf test
720e3bc
@glyh
hardfork test: add CI job for advanced fork method
1d6e6ab
@glyh
FIX(hardfork test advanced): use compatible as prefork network as the…
ed48489 
… RPC haven't entered master yet
@glyh
FIX(hardfork test advanced): set a proper client port for advanced fo…
f892d4d 
…rk config generation
@glyh
hf test go: bump down a bunch of parameters to make test run faster &
8cbfa76 
lighter
@glyh
fix(advanced hardfork test): ensure cli command is called before netw…
818ab4c 
…ork is shutdown
@glyh
fix(advanced hardfork test): don't prepare fork config dir as advance…
971f0cd 
…d hf test require that dir to be absent
@glyh
hf test go: add a note for further refactoring on legacy fork
ccbd0f3
@glyh
report if inherit_with doesn't have existing config
428a806
@glyh
mina-local-network.sh: print the conifg that's inherited
028948b
@glyh
FIX: hardfork: run patch hf config script once not twice!
eb7e25b
@glyh
hardfork test advanced: set --generate-fork-validation to false to …
ae858b6 
…speed up fork config generation
@glyh
hardfork test advanced: remove patching genesis time stamp after gene…
a43ce0c 
…rated fork config
@glyh
mina local network: support overriding daemon.hard_fork_genesis_slot_…
b1d050b 
…delta in daemon config
@glyh
hardfork test: set hardfork-genesis-slot-delta in main network if usi…
04231c3 
…ng advanced mode
@glyh
FIX(hardfork test): in fork network, don't delay the genesis. It's al…
086b584 
…ready delayed in legacy mode when patching genesis config. And in advanced mode we've have a calculated genesis that shouldn't be overridden
@glyh
bump up fork delay now that we're not waiting double fork delay befor…
002944d 
…e genesis of fork network
@glyh
legacy hf test: refactor hashes, pre&post-patch config validation
7d2ffbd
@glyh
hf test go legacy: factor out final config validation
7004d47
@glyh
hf test go advanced: implement validation for fork config
47d8f4e
@glyh
FIX(hf test go legacy): patch timestamp to RFC3339 format so it could be
3d881c2 
parsed by config validation
@glyh
mina local network: show what's being overriden
6c403dc
@glyh glyh force-pushed the lyh/hf-test-go/advanced-generate-hf-config branch from 1e4e4f1 to 6c403dc Compare December 3, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glyh