[CI] Use script for monorepo logic #18184
Open
+101
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!ci-build-me |
6 similar comments
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/move_triaging_to_bash
branch
from
4dcc752 to
a6aa7c1
Compare
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-nightly-me |
Member
Author
Member
Waiting for nightly |
dkijania
force-pushed
the
dkijania/move_triaging_to_bash
branch
from
a6aa7c1 to
3abda6b
Compare
Member
Author
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit maximum length of step when I added additional drityWhen filter to one of the jobs:
https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/39708#019ade81-a113-44fb-b6f6-23a8c004c234
My solution is to delegate logic which decide if job should be triggered or not based to bash script. Thanks to that we can shorten step code.
P.S. I choose bash as it is most natural and most commonly used in CI. If we would like to use different language we need to install it on toolchain first etc. Currently its to big lift .