Update zkapp permission fallback logic v2 #18189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
force-pushed
the
lyh/mesa/zkapp-fallback-logic
branch
from
fa05fcf to
1074217
Compare
glyh
force-pushed
the
lyh/mesa/zkapp-fallback-logic
branch
from
1074217 to
e4188ed
Compare
glyh
force-pushed
the
lyh/mesa/zkapp-fallback-logic
branch
from
e4188ed to
3793c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #18142
It differs from that PR in that:
set_permissionsThe common part of this PR and V1 is that they both implement fallback for
accessCI would fail because we've touched on txn snark structure, but I'd like to get some reviews before regenerating them, as it's slow to regenerate.