WIP optimize Ram in scan states #18191
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step towards using multi-key file storage tags instead of witnesses and proofs stored in memory.
Function is a duplicate of `Transaction_applied.transaction_with_status`
Function is a duplicate of `Transaction_applied.transaction_status`
This is an intermediate step to simplify definition of the scan state.
Introduce a functor to allow usage of functionality with different
transactiuon representations.
Rename {first_and_second_pass -> categorize}_transactions_xx
Streamline handling of boolean determining whether transactions are continued in the next tree.
This is only useful for as long as we need to maintain the legacy flow of loading frontier from disk. But it's useful for testing before that is fully delivered.
This reverts commit c537af4.
This reverts commit 6213263675ad6ef0dda6aeb4ca18473cc4961659.
It's safe to remove multi-key file storage files only once corresponding blocks may not be possible referred by the Daemon. For orphan blocks it's ok to remove them during root transition. For old roots it's not the case, because entries in scan states may still be referring old blocks. Assumption: root history capacity (2k, or 580 blocks) ensures that any entry in scan state from the root transition will be referincing a block there. Also for root history structure in Daemon there is a similar guarantee.
Member
Author
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that will be split to many smaller PRs.
I open it for ease of tracking the full workload.
PR is extensively documented in notion.