Skip to content

Disable total currency in frontier visualization #18197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjjdespres wants to merge 2 commits into
base: compatible
Choose a base branch
from
Open

Disable total currency in frontier visualization #18197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee33436
Disable total currency in frontier visualization
cjjdespres Dec 4, 2025
023d218
Add changelog for 18197
cjjdespres Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changes/18197.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Fix a bug that causes the daemon to freeze when shut down with a signal like
SIGINT or SIGTERM, and not with `mina client stop`. The frontier visualization
debug diagram that is written at shutdown will now display a total_currency of 0
for every mask. This functionality will be restored when the efficiency of the
underlying operation is improved.
21 changes: 14 additions & 7 deletions src/lib/merkle_mask/maskable_merkle_tree.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,20 @@ module Make (Inputs : Inputs_intf) = struct
let display_attached_mask mask =
let root_hash = Mask.Attached.merkle_root mask in
let num_accounts = Mask.Attached.num_accounts mask in
let total_currency =
Mask.Attached.foldi mask ~init:0 ~f:(fun _ total_currency account ->
(* only default token matters for total currency *)
if Token_id.equal (Account.token account) Token_id.default then
total_currency + (Balance.to_int @@ Account.balance account)
else total_currency )
in
(* This total_currency computation is temporarily disabled - it causes the
frontier mask visualization that happens at shutdown to be
exceptionally slow. See #17501 and #18196, though if we decide we
really need this then we could also consider optionally caching the
total_currency in ledger masks, and then recomputing the currency
change each mask would cause in the ledger. *)
(* let total_currency =
Mask.Attached.foldi mask ~init:0 ~f:(fun _ total_currency account ->
(* only default token matters for total currency *)
if Token_id.equal (Account.token account) Token_id.default then
total_currency + (Balance.to_int @@ Account.balance account)
else total_currency )
in *)
let total_currency = 0 in
let uuid = format_uuid mask in
{ hash =
Visualization.display_prefix_of_string
Expand Down