Fix World.from_dict to pass required __init__ parameters #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
World.from_dictclass method was callingWorld.__init__with only 2 of the 4 required positional arguments (name, size, seed, generation_params), causing instantiation to fail.Changes
World.from_dictto extract and passseedandgeneration_paramsfrom the input dictionaryThis matches the pattern used in
_from_protobuf_worldand ensures proper World object initialization from dictionary representations.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.