[VirtualInput] Fix subticks not being recorded in GuiScreens #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScribbleTAS
added
Bug
Core
PancakeTAS
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What a weird oversight
Up to now, subticks were not recorded in Gui screens.
Reason was that nextTickKeyboard (and Mouse) is called twice when a GuiScreen is open.
nextTickKeyboard adds the current keyboard to the PlaybackController, where it will be recorded at the end of the tick,
then clears the subticks of that keyboard.
By calling the method twice, a keyboard without subticks overwrites the keyboard in the PlaybackController, making it record a subtickless keyboard to the inputs.