Skip to content

Conversation

@ScribbleTAS
Copy link
Member

@ScribbleTAS ScribbleTAS commented Mar 24, 2025

  • Fixes Pressing ESC opens the ingame menu instead of closing the current gui #224
  • [Flavor] More documentation
  • [Serialiser] Fix additional MOUSEMOVED and ZERO inputs being deserialised
  • [PlaybackController] Rename TickContainer to InputContainer
  • Update loom and workflows
  • [Serialiser] Fix first subtick getting skipped
  • [Serialiser] Fix relative values not working in subticks
  • [VirtualInput] Fix inputs running twice in cases where a gui screen is involved

@ScribbleTAS ScribbleTAS added Bug Core Issue relates to core concepts Gui Issue relates to guis labels Mar 24, 2025
@ScribbleTAS ScribbleTAS added this to the Beta1.0 milestone Mar 24, 2025
@ScribbleTAS ScribbleTAS self-assigned this Mar 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in TASmod Mar 24, 2025
- Fixes Gui Inputs not being properly recognised
It just makes more sense at this point...
@ScribbleTAS ScribbleTAS moved this from Todo to In Progress in TASmod Mar 30, 2025
@ScribbleTAS ScribbleTAS marked this pull request as ready for review March 30, 2025 16:45
@ScribbleTAS ScribbleTAS requested a review from PancakeTAS March 30, 2025 16:45
@ScribbleTAS ScribbleTAS merged commit d5436dc into MinecraftTAS:develop Mar 30, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in TASmod Mar 30, 2025
@ScribbleTAS ScribbleTAS deleted the fix/gui branch March 30, 2025 20:03
@PancakeTAS PancakeTAS requested a review from Copilot March 31, 2025 20:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes various issues related to recording and playing back GUI inputs by renaming TickContainer to InputContainer and updating associated serialization, deserialization, and file command functionality. Key changes include:

  • Renaming and refactoring of TickContainer to InputContainer across the codebase.
  • Adjustments to methods in serialisation/deserialization and filecommands to support the new type.
  • Updates to build workflows to use Java 23 and Gradle 8.13.

Reviewed Changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
SavestateHandlerClient.java Replaced TickContainer with InputContainer for saved state loading.
AlphaFlavor.java Updated methods to use InputContainer and changed key deserialization to use Sets.
SerialiserFlavorBase.java Modified serialization methods, documentation, and renamed previousTickContainer to previousInputContainer.
PlaybackSerialiser.java Adjusted file save/load methods to use InputContainer.
File command extensions (.java) Updated interfaces and methods to work with InputContainer.
PlaybackControllerClient.java Replaced TickContainer with InputContainer and updated container management.
Mixin classes (MixinMinecraft, MixinGuiSlot, MixinGuiScreen) Adjusted injection methods to support input handling fixes.
Build workflows (.yml) Upgraded Java and Gradle versions in CI/CD configuration.
Files not reviewed (1)
  • gradle.properties: Language not supported
Comments suppressed due to low confidence (1)

src/main/java/com/minecrafttas/tasmod/playback/PlaybackControllerClient.java:639

  • Consider also cloning the 'comments' field in the clone() method so that the cloned InputContainer does not share mutable comment state with the original.
public InputContainer clone() { return new InputContainer(keyboard, mouse, cameraAngle); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Issue relates to core concepts Gui Issue relates to guis

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Pressing ESC opens the ingame menu instead of closing the current gui

2 participants