-
-
Notifications
You must be signed in to change notification settings - Fork 7
[VirtualInput] Fix recording/playing back gui inputs not working correctly #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixes Gui Inputs not being properly recognised
It just makes more sense at this point...
…en loading a file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes various issues related to recording and playing back GUI inputs by renaming TickContainer to InputContainer and updating associated serialization, deserialization, and file command functionality. Key changes include:
- Renaming and refactoring of TickContainer to InputContainer across the codebase.
- Adjustments to methods in serialisation/deserialization and filecommands to support the new type.
- Updates to build workflows to use Java 23 and Gradle 8.13.
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SavestateHandlerClient.java | Replaced TickContainer with InputContainer for saved state loading. |
| AlphaFlavor.java | Updated methods to use InputContainer and changed key deserialization to use Sets. |
| SerialiserFlavorBase.java | Modified serialization methods, documentation, and renamed previousTickContainer to previousInputContainer. |
| PlaybackSerialiser.java | Adjusted file save/load methods to use InputContainer. |
| File command extensions (.java) | Updated interfaces and methods to work with InputContainer. |
| PlaybackControllerClient.java | Replaced TickContainer with InputContainer and updated container management. |
| Mixin classes (MixinMinecraft, MixinGuiSlot, MixinGuiScreen) | Adjusted injection methods to support input handling fixes. |
| Build workflows (.yml) | Upgraded Java and Gradle versions in CI/CD configuration. |
Files not reviewed (1)
- gradle.properties: Language not supported
Comments suppressed due to low confidence (1)
src/main/java/com/minecrafttas/tasmod/playback/PlaybackControllerClient.java:639
- Consider also cloning the 'comments' field in the clone() method so that the cloned InputContainer does not share mutable comment state with the original.
public InputContainer clone() { return new InputContainer(keyboard, mouse, cameraAngle); }
Uh oh!
There was an error while loading. Please reload this page.