[FileCommands] Refactor, documentation and fixes #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScribbleTAS
added
the
TASFile
ScribbleTAS
force-pushed
the
refactor/filecommands
branch
from
4353cb1 to
4b3930b
Compare
- Split PlaybackFileCommandContainer into SortedFileCommandContainer and UnsortedFileCommandContainer - Created FileCommandsInCommentList and FileCommandsInTickList instead of List<PlaybackFileCommand> to better point out the difference - Add sort and unsort for better visibility instead of sorting in the constructor of PlaybackFileCommandContainer
- Added default serialisation fixes - Fixed MinecraftTAS#231 - Fixed multiple inline FileCommands failing - Fixed loading FileCommands not clearing the previous FileCommands
ScribbleTAS
force-pushed
the
refactor/filecommands
branch
from
4b3930b to
4601a2d
Compare
- Fixed equals not working correctly in SortedFileCommandContainer
PancakeTAS
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Filecommands have some overengineered data sorting built in, when using them in the serilialiser vs. using them during playback.
To better visualise this, I created 2 seperate "containers", unsorted and sorted which are used in serialising and playback respectively.
Additionally, I used an
ArrrayList<PlaybackSerialiser>in both containers, but the format in this list is actually different and this lead to a lot of confusion while trying to figure out my own code...So instead, I added 2 classes that extend
ArrrayList<PlaybackSerialiser>called FileCommandsInCommentList and FileCommandsInTickList to better visualize the format and to add documentation... Which should hopefully make this less confusing...Fixes