[Savestates] Fix input preloading when loadstating during a recording #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch client savestates from Files to Paths (Now that I understand them better)
ScribbleTAS
force-pushed
the
fix/preload
branch
from
404e0bd to
b751a53
Compare
…t/right Another bug found by ACatThatCanParkourReallyWell9900, thanks!
ScribbleTAS
force-pushed
the
fix/preload
branch
from
54747cf to
13a982e
Compare
This only happens when the controller is not playing back or recording
- Trying to fix preloading in recording
- Fix line endings in MixinNetHandlerPlayClient - Small variable change in VirtualInput
ScribbleTAS
changed the title
PancakeTAS
approved these changes
May 1, 2025
ScribbleTAS
added a commit
that referenced
this pull request
May 28, 2025
…248) In #240 I added a "[VirtualInput] Fix camera being reset to 0 -180 when entering a world", which introduced this crash. Reason is that the "onDoneLoadingPlayer" event, that I introduced in that PR, is also fired when switching dimensions. And switching dimensions in this case sets the virtual camera to null, which crashes the playback with a NullPointerException. And being once again confronted with this "clearing the virtual camera angle at the right moment" problem I realized that this system is pretty idiotic... To fix this, the virtual camera is now set to null when leaving the game and then initialised when the player is done loading. This way, the player should retain it's camera angle on world load and the camera angle shouldn't become null unexpectedly. Changes - Rewrote camera resetting and moved it to LoadingScreenHandler - Seperated clearing the next camera angle from clear() and renamed the method to clearKeys() - Added clearNext() to keyboard, mouse and camera - Updated documentation - Changed method names in MixinEntityRenderer to start with `playback` for better consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.