[Serialiser] Fix some inputs sometimes not being saved #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScribbleTAS
added
the
TASFile
PancakeTAS
approved these changes
May 5, 2025
Fixed a race condition in the FileThread that prevents some inputs at the end of the file not getting serialised.
ScribbleTAS
force-pushed
the
fix/input-saving
branch
from
dd908ee to
4f76386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a race condition in the FileThread that
prevents some inputs at the end of the file not getting serialised.
Switched the collection type from an arraylist to a queue and added an extra safety writeOutput, after the thread is closed