[Savestates] Fixed index being set to 0 when using fullplay #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A temporary fix that just sets the index to the latest index, this is not entirely correct. But this at least minimizes the chance that you accidentally overwrite something. Fixing this requires a bit of a indexing redesign
PancakeTAS
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix until the indexing system is reworked...
My plan is to use the indexing system from LoTAS-Light at some point, where this issue is fixed...
Sets the index to the latest index instead of 0 when savestate 0 is loaded. Not ideal, but this minimizes the chance of accidentally overwriting something.