Skip to content

✨ feat: implement strict mode#57

Merged
Minemetero merged 10 commits intomainfrom
feat/strict-mode
Jun 3, 2025
Merged

✨ feat: implement strict mode#57
Minemetero merged 10 commits intomainfrom
feat/strict-mode

Conversation

@Minemetero
Copy link
Owner

@Minemetero Minemetero commented May 20, 2025

  • after 10:10 who ever get 2 point wins
  • 2 balls change server to 1 ball
  • Fix the pop up hint
  • UI improvement

@Minemetero Minemetero changed the title ✨ feat: implement strict mode (win by 2 points after 10-10) ✨ feat: implement strict mode May 20, 2025
@Minemetero

This comment was marked as off-topic.

This was linked to issues May 20, 2025
@Minemetero

This comment was marked as resolved.

@GeoDaoyu

This comment was marked as resolved.

@Minemetero

This comment was marked as off-topic.

@Minemetero

This comment was marked as outdated.

@Minemetero

This comment was marked as outdated.

@Minemetero

This comment was marked as outdated.

@Minemetero

This comment was marked as off-topic.

@Minemetero

This comment was marked as off-topic.

@Minemetero

This comment was marked as resolved.

@Minemetero Minemetero requested a review from lingbopro May 20, 2025 04:59
@Minemetero Minemetero marked this pull request as ready for review May 20, 2025 05:03
@Minemetero Minemetero moved this from Backlog to In review in Table-Tennis-Counter Roadmap May 20, 2025
@GeoDaoyu

This comment was marked as resolved.

@Minemetero

This comment was marked as resolved.

@Minemetero

This comment was marked as resolved.

@GeoDaoyu

This comment was marked as resolved.

@Minemetero

This comment was marked as resolved.

@Minemetero
Copy link
Owner Author

丑了点,lingbo 你看看。修修 :p

@lingbopro
Copy link
Collaborator

目前功能应该是没问题的,我以我的看法给UI提个建议

首先 Strict Mode 我觉得应该加个解释,不然用户容易不知道干什么用的

另外这个开关可能放上面比较合适,放下面容易导致用户填完数据才发现 Strict Mode 的功能,特别是如果用户填的参数被这个功能覆盖了

还有 Strict Mode 关闭后是不是应该把填的参数还原回去,防止用户的参数被覆盖(呼应上一段)

:)

@Minemetero
Copy link
Owner Author

目前功能应该是没问题的,我以我的看法给UI提个建议

首先 Strict Mode 我觉得应该加个解释,不然用户容易不知道干什么用的

另外这个开关可能放上面比较合适,放下面容易导致用户填完数据才发现 Strict Mode 的功能,特别是如果用户填的参数被这个功能覆盖了

还有 Strict Mode 关闭后是不是应该把填的参数还原回去,防止用户的参数被覆盖(呼应上一段)

:)

switch 放在上面。。。ermmmmm 不好看吧

@Minemetero
Copy link
Owner Author

那我还得写个逻辑给他们localStorage是吧。不想写了啊

@lingbopro
Copy link
Collaborator

那我还得写个逻辑给他们localStorage是吧。不想写了啊

不是,我的意思是打开 Strict Mode 的时候把之前的值存到变量里,关掉的时候就把变量赋值回去

@lingbopro
Copy link
Collaborator

不过把参数保存起来是个好想法()

@lingbopro
Copy link
Collaborator

switch 放在上面。。。ermmmmm 不好看吧

放下面也行,但是最好提示用户这个功能会改数据,或者做参数还原

Copy link
Collaborator

@lingbopro lingbopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得可以并了

@Minemetero
Copy link
Owner Author

那我还得写个逻辑给他们localStorage是吧。不想写了啊

不是,我的意思是打开 Strict Mode 的时候把之前的值存到变量里,关掉的时候就把变量赋值回去

这个不做了是吧 :)

@Minemetero
Copy link
Owner Author

@lingbopro 可以套一个s-tooltip

@lingbopro
Copy link
Collaborator

@lingbopro 可以套一个s-tooltip

但是用户不一定会把鼠标往上放,特别是移动端

而且文字标签上面放tooltip感觉怪怪的(

我觉得可以在文字下面放一行偏灰的小字

@lingbopro
Copy link
Collaborator

或者说可以放一个问号的图标,这样可以指引用户把鼠标放上去

@Minemetero
Copy link
Owner Author

或者说可以放一个问号的图标,这样可以指引用户把鼠标放上去

勾引

@Minemetero
Copy link
Owner Author

或者说可以放一个问号的图标,这样可以指引用户把鼠标放上去

我是想说可以套个tooltip到switch上

@lingbopro
Copy link
Collaborator

或者说可以放一个问号的图标,这样可以指引用户把鼠标放上去

我是想说可以套个tooltip到switch上

干脆套到整个form-group上吧

@lingbopro
Copy link
Collaborator

我觉得在文字后面放一个问号图标起码让用户知道这有提示信息,不然用户可能根本不往那点

@Minemetero
Copy link
Owner Author

要不然合并算了?

@Minemetero
Copy link
Owner Author

或者说可以放一个问号的图标,这样可以指引用户把鼠标放上去

我是想说可以套个tooltip到switch上

干脆套到整个form-group上吧

ermmmmm不太好

@lingbopro
Copy link
Collaborator

我是想说可以套个tooltip到switch上

干脆套到整个form-group上吧

ermmmmm不太好

要不然就套文字+问号,或者switch+问号

@Minemetero
Copy link
Owner Author

合并的了
让用户自己摸索不管了 :/

@Minemetero Minemetero merged commit e3b37c7 into main Jun 3, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in Table-Tennis-Counter Roadmap Jun 3, 2025
@GeoDaoyu
Copy link
Contributor

GeoDaoyu commented Jun 3, 2025

合并的了 让用户自己摸索不管了 :/

等用户用了再提issue吧

@Minemetero
Copy link
Owner Author

合并的了 让用户自己摸索不管了 :/

等用户用了再提issue吧

sober出毛病了

@Minemetero Minemetero deleted the feat/strict-mode branch September 23, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feat: add Extra Points

3 participants