Conversation
KrystilizeNevaDies
left a comment
KrystilizeNevaDies
left a comment
There was a problem hiding this comment.
These are my thoughts on some of the high level stuff, it's up to you @GoldenStack if you want to address my comments or ask @Garrett-EMS to
blocks/src/main/java/net/minestom/vanilla/fluids/MinestomFluids.java
Outdated
Show resolved
Hide resolved
| public class FluidUtils { | ||
|
|
||
| public static Point raycastForFluid(Player player, Point startPosition, Vec direction, double maxDistance) { | ||
| Point currentPosition = startPosition; |
There was a problem hiding this comment.
You should be able to do a sweep cast here as opposed to an approximation.
IIRC it's something like boundingBox.sweep().
BlockIterators might also be useful.
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Why are there these random resource json files?
You should be able to extract these from the datapack instead.
There was a problem hiding this comment.
fyi: Not all of them are in the vanila tags (i.e. vri:glass_panes don't exist as a block tag)
| * Interface for tag providers that check if elements are tagged and can return sets of elements with specific tags | ||
| * @param <T> The type of element being tagged | ||
| */ | ||
| public interface TagProvider<T> { |
There was a problem hiding this comment.
We should remove this in favor of our current tags system, or merge/replace it into our current tag system.
Ideally all these tags should be fetched from the datapack.
| * Ported from Kotlin to Java and adapted for use in this project with modifications. | ||
| */ | ||
| public class CandlePlacementRule extends BlockPlacementRule { | ||
| private static final Map<Block, Block> CANDLE_CAKE = new HashMap<>(); |
There was a problem hiding this comment.
Use a Map#of or Map#copyOf at the end and assign it to this.
| CANDLE_CAKE.put(Block.BLACK_CANDLE, Block.BLACK_CANDLE_CAKE); | ||
| } | ||
|
|
||
| public static Map<Block, Block> getCANDLE_CAKE() { |
| */ | ||
| public class CandleCakeRule implements BlockHandler { | ||
| private final Block block; | ||
| private static final Map<Block, Block> CAKE_CANDLE = new HashMap<>(); |
| */ | ||
| public class CopperOxidationRule implements BlockHandler { | ||
| private final Block block; | ||
| public static final Map<Block, Block> oxidationStages = new HashMap<>(); |
Garrett-EMS
force-pushed
the
rework/blocks
branch
from
8b0b667 to
d200260
Compare
|
Btw you've included the client jar in this pr, it should be removed lol |
|
Will do that. @GoldenStack any updates on reviewing this? |
4 participants
port blocks n stuff to java from kotlin