Vanilla Commands Rework and Additions#65
Open
wi1helm wants to merge 7 commits intoMinestom:masterfrom
Open
Conversation
Started to rework and add vanilla commands: Added permission checks and levels taken from mc wiki. added some easy to have commands.
Make VanillaCommands a abstract class instead of interface. Changed VanillaCommandsFeature to not be a enum and more dynamic
Updated Help command to be closer to vanilla. Reworked VanillaCommandsFeature again and removed supplier. Easy to use.
All commands now use translation keys for messages.
tatteaid
reviewed
Jul 18, 2025
| public final int LEVEL_MODERATOR = 1; | ||
| public final int LEVEL_GAMEMASTER = 2; | ||
| public final int LEVEL_ADMIN = 3; | ||
| public final int LEVEL_OWNER = 4; |
There was a problem hiding this comment.
I think this should be a static constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework:
Created a VanillaCommands class that includes vanilla permissions check and usage(used for help command).
Changed around in VanillaCommandFeature to make the logic more simple.
All previous commands have in someway been changed to extend VanillaCommand and additions like translation keys.
Additions:
/op (has wrong permission level right now due to no console.)
/list
/me
/msg
/help
/say
These commands have simple logic that dont need other implementations like entities (/summon), worldgen (/seed) etc.