Skip to content

Profiler totals row should not be part of results. #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nateberkopec merged 3 commits into from
Apr 13, 2025
+3 −2
Merged

Profiler totals row should not be part of results. #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22ab303
Profiler totals rows are not part of results.
DropsOfSerenity Jan 30, 2025
5beb8ec
changelog entry + version bump
DropsOfSerenity Mar 28, 2025
e36779e
Merge branch 'master' into master
DropsOfSerenity Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [FIX] `flamegraph_mode` query param having no effect. [#635](https://github.com/MiniProfiler/rack-mini-profiler/pull/635)
- [FEATURE] Show record type and count in SQL query UI. [#638](https://github.com/MiniProfiler/rack-mini-profiler/pull/638)
- [FEATURE] Show Active Record QueryCache hits in UI. [#640](https://github.com/MiniProfiler/rack-mini-profiler/pull/640)
- [FIX] max_traces_to_show had chance to break the profiler frontend [#297](https://github.com/MiniProfiler/rack-mini-profiler/issues/297)

## 3.3.1 - 2024-02-15
- [FEATURE] Support dynamic `config.content_security_policy_nonce` [#609](https://github.com/MiniProfiler/rack-mini-profiler/pull/609)
Expand Down
4 changes: 2 additions & 2 deletions lib/html/includes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,10 @@ var _MiniProfiler = (function() {
}); // limit count

if (
container.querySelectorAll(".profiler-result").length >
container.querySelectorAll(".profiler-result:not(:has(.profiler-totals))").length >
options.maxTracesToShow
) {
var elem = container.querySelector(".profiler-result");
var elem = container.querySelector('.profiler-result:not(:has(.profiler-totals))');

if (elem) {
elem.parentElement.removeChild(elem);
Expand Down
Loading