feat: add support for other path types #237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
sybrenjansen
suggested changes
May 6, 2025
sybrenjansen
left a comment
sybrenjansen
left a comment
There was a problem hiding this comment.
Unfortunately, it fails when loading the Tokenizer. I guess, because it's rust based, it doesn't take cloudpaths :/ Not sure what is the best approach here.
|
|
||
| if isinstance(path, Path): | ||
| # Only check if we're sure this is a path. | ||
| # It could be a cloudpathlib path, or something else. |
There was a problem hiding this comment.
In this if statement path is always a Path. I.e., AnyPath doesn't have Path as base class, so this comment isn't true
Contributor
Author
|
@sybrenjansen if tokenizer loading fails using a CloudPath, I think it's best to just download the folder and load everything using |
|
Yeah, I guess that's the only way. Oh well. Thnx anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234
This PR adds support for cloudpathlib indirectly.