Skip to content

Reduce logging #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rxsto wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reduce logging #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e09b23
chore: avoid warning about passthrough
rxsto Jan 14, 2026
685f92a
chore: avoid duplicated addUser call
rxsto Jan 14, 2026
33e5452
Merge branch 'master' into chore/reduce-logging
rxsto Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ public synchronized void addUser(long userId) {
return;
}

if (decryptors.containsKey(userId)) {
return;
}

log.debug("Adding user {}", userId);
DaveDecryptor decryptor = decryptors.computeIfAbsent(userId, id -> DaveDecryptor.create(id, session));
decryptor.prepareTransition(currentProtocolVersion);
Expand Down Expand Up @@ -299,7 +303,13 @@ private void prepareProtocolTransition(int transitionId, int protocolVersion) {

private void executeProtocolTransition(int transitionId) {
Integer protocolVersion = preparedTransitions.remove(transitionId);

if (protocolVersion == null) {
if (transitionId == DaveConstants.INIT_TRANSITION_ID) {
log.debug("Passing through transition with ID 0");
return;
}

log.warn("Unexpected Transition ID {}", transitionId);
return;
}
Expand Down