Skip to content

fix: Use eval_duration for output TPS calculations in Ollama LLM provider #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: Use eval_duration for output TPS calculations in Ollama LLM provider #4568

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca905f9
fix: Use eval_duration for output TPS calculations and add as a metri…
jonathanortega2023 Oct 21, 2025
5a62844
refactor usage of eval_duration from ollama metrics
shatfield4 Oct 22, 2025
a233373
Merge branch 'master' into pr-4568-branch
shatfield4 Oct 22, 2025
809e5ac
move eval_duration to usage
shatfield4 Oct 22, 2025
7831b16
overwrite duration in ollama provider wip measureAsyncFunction option…
shatfield4 Oct 25, 2025
b33c84d
allow for overloaded duration in measureAsyncFunction
shatfield4 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions server/utils/AiProviders/ollama/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ class OllamaAILLM {
if (chunk.done) {
usage.prompt_tokens = chunk.prompt_eval_count;
usage.completion_tokens = chunk.eval_count;
usage.eval_duration = chunk.eval_duration / 1e9;
writeResponseChunk(response, {
uuid,
sources,
Expand All @@ -362,9 +363,6 @@ class OllamaAILLM {
});
response.removeListener("close", handleAbort);
stream?.endMeasurement(usage);
stream.metrics.eval_duration = chunk.eval_duration / 1e9;
stream.metrics.outputTps =
stream.metrics.completion_tokens / stream.metrics.eval_duration;
resolve(fullText);
break;
}
Expand Down
8 changes: 7 additions & 1 deletion server/utils/helpers/chat/LLMPerformanceMonitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const { TokenManager } = require("../tiktoken");
* @property {number} total_tokens - the total number of tokens
* @property {number} outputTps - the tokens per second of the output
* @property {number} duration - the duration of the stream
* @property {number} [eval_duration] - optional eval duration from providers (e.g., Ollama) used for more accurate outputTps calculation
*/

/**
Expand Down Expand Up @@ -88,7 +89,12 @@ class LLMPerformanceMonitor {

stream.metrics.total_tokens =
stream.metrics.prompt_tokens + (stream.metrics.completion_tokens || 0);
stream.metrics.outputTps = stream.metrics.completion_tokens / duration;

// Use eval_duration if provided (for providers like Ollama that report it)
// otherwise fall back to total request duration
stream.metrics.outputTps =
stream.metrics.completion_tokens /
(stream.metrics.eval_duration || duration);
stream.metrics.duration = duration;
return stream.metrics;
};
Expand Down