Reorder workspace threads by latest interaction#4857
Open
shatfield4 wants to merge 8 commits intomasterfrom
Open
Reorder workspace threads by latest interaction#4857shatfield4 wants to merge 8 commits intomasterfrom
shatfield4 wants to merge 8 commits intomasterfrom
Conversation
frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx
Outdated
Show resolved
Hide resolved
Contributor
angelplusultra
left a comment
There was a problem hiding this comment.
LGTM. Only nitpick would be maybe this:
if (threadSlug) {
window.dispatchEvent(
new CustomEvent(THREAD_ACTIVITY_EVENT, {
detail: { threadSlug },
})
);
}is written multiple times around, maybe abstract to a utility fn?
export function dispatchThreadActivityEvent(threadId){
if (threadSlug) {
window.dispatchEvent(
new CustomEvent(THREAD_ACTIVITY_EVENT, {
detail: { threadSlug },
})
);
}
}
Collaborator
Author
|
Fixed code duplication problem by creating reusable |
frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4844
What is in this change?
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes