Conversation
…action buttons functional
|
@shatfield4 I know this is not ready but some feedback:
We might want to make another PR after this to fix the reset message - it causes the page shift as if a chat was sent if you send it first. |
…911-feat-home-page-redesign-implementation
angelplusultra
left a comment
There was a problem hiding this comment.
Overall this looks great. I just left a few notes.
My biggest concern is the home page defaulting to the last visited workspace without clearly indicating which workspace that is. If you don’t remember where you were last, submitting a prompt from the home page becomes a bit of a dice roll. It may be worth considering a way to clearly display the targeted workspace.
angelplusultra
left a comment
There was a problem hiding this comment.
Overall looks solid and works great. I have one refactor suggestion for code maintainability.
The greeting + PromptInput + QuickActions + SuggestedMessages layout is largely duplicated between Home/index.jsx:256-293 and ChatContainer/index.jsx:329-397. Both render the same structure with slightly different wiring. Consider extracting this into a shared component (e.g., EmptyStateView) to reduce duplication and ensure visual consistency.
Took a crack at extracting this to a shared component but due to the wiring and differences in props, this extraction would make the overall implementation more complex. In the future we may want to add new components to only the home page so IMO it is a good idea to keep these separate for now. |
There was a problem hiding this comment.
Discovered issues:
If i upload a file I can click the "x" to remove them as parsed files but hoving over the paperclip i cannot click the X to remove it as a parsed file via the modal.
The new landing page logic works for admins, but for managers and default level users this logic does not work.
Managers can create workspaces - so they should be able to create a new workspace and send a chat and auto-create a workspace. Instead it makes me choose a workspace or tells me i have none. If i open a workspace the empty state exists
For users, this is nonfunctional in a similar way. If i have a workspace then direct me to the new landing so i can send a chat instantly. If i have no workspaces then i should see the "contact system admin" landing page.
We need to confirm for the command prompt and agent prompt popovers are correctly laid out when the input modal is tall. I dont think this is the layout we want.
As an admin, if i have a workspace we can assume to send chats to - the sidebar does not show it - here i am actually about to send a prompt to MyWorkspace, which has 3 threads already. I am on the root page, but its not clear where I am about to send a chat.
I can confirm that actually happens in single user mode too - if we are assuming a workspace we should highlight on sidebar along with thread if we are tracking it. Otherwise whatever the assumed workspace is should be expanded too.
Change model is missing - when the prompt is showing and assuming a present workspace as to where we are chatting we should enable showing the model change "brain" icon. When the workspace does not yet exist - we should not show this icon.
This record in the translations does not exist (i cant find it??) and it's not in the associated translation PR. Additionally, this same fallback string should just be a constant so its in one place. However, just making a real record in EN would make it the fallback for any null language entry once normalized.
Create An agent quick-action is showing for managers - who cannot access this page.
|
Pull Request Type
Relevant Issues
resolves #4911
What is in this change?
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes