feat(New Model): Add support for gpt5#52
Conversation
| "extra_body": extra_body, | ||
| } | ||
|
|
||
| if self.model_name == "gpt-5-2025-08-07" or self.model_name == "gpt-5": |
There was a problem hiding this comment.
I would suggest we make a new Python file called something like gpt-5_openai_chat_client.py.
Otherwise, the name can be a bit misleading to have Claude + open_router client for GPT-5 support.
|
Also add docs for GPT-5 would be good to make it complete. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GPT-5, a new model from OpenAI, by implementing a dedicated client and configuration files to enable GPT-5 evaluation on the GAIA validation benchmark.
- Implements
GPT5OpenAIClientwith specific GPT-5 model handling and reasoning effort configuration - Adds comprehensive documentation and configuration files for GPT-5 usage
- Updates tools and documentation to reflect the new GPT-5 support
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/llm/providers/gpt5_openai_client.py | New GPT-5 client implementation with OpenAI API integration |
| src/llm/provider_client_base.py | Adds reasoning_effort parameter to base client |
| config/agent_gaia-validation-gpt5.yaml | GAIA validation configuration for GPT-5 |
| docs/mkdocs/docs/gaia_validation_gpt5.md | Documentation for GPT-5 GAIA validation |
| docs/mkdocs/docs/openai-gpt.md | Updated OpenAI documentation with GPT-5 info |
| docs/mkdocs/docs/llm_clients_overview.md | Added GPT-5 client to overview table |
| docs/mkdocs/mkdocs.yml | Added GPT-5 page to navigation |
| config/tool/tool-reading.yaml | Added environment variables for tool configuration |
| src/tool/mcp_servers/vision_mcp_server.py | Added file URL parsing functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| agent-worker: | ||
| prompt_class: SubAgentWorkerPrompt | ||
| llm: | ||
| provider_class: "ClaudeOpenRouterClient" |
There was a problem hiding this comment.
Inconsistent configuration: using ClaudeOpenRouterClient with GPT-5 model. This should use GPT5OpenAIClient to match the model type.
| provider_class: "ClaudeOpenRouterClient" | |
| provider_class: "GPT5OpenAIClient" |
* add gpt5 * fix some bug * fix * update gpt5 * add doc, fix some bug * fix gpt-5
Describe this PR
Added support for gpt5. You can use the configuration file config/agent_gaia-validation-gpt5.yaml to evaluate gaia-validation.
Checklist for PR
Must Do
feat(agent): add pdf tool via mcp,perf: make llm client asyncandfix(utils): load custom config via importlibetc. CI jobcheck-pr-titleenforces Angular commit message format to PR title.make precommitlocally. CI joblintenforce ruff default format/lint rules on all new codes.make pytest. Check test summary (located atreport.html) and coverage report (located athtmlcov/index.html) on new codes.Nice To Have
/testsforfeatandtestPR./docsfordocsandciPR.