Skip to content

fix: TaskTracer validation error (Fixes #55)#56

Merged
BinWang28 merged 1 commit intoMiroMindAI:miroflow-v0.3from
zmyzxb:fix/55-TaskTracer-error
Sep 29, 2025
Merged

fix: TaskTracer validation error (Fixes #55)#56
BinWang28 merged 1 commit intoMiroMindAI:miroflow-v0.3from
zmyzxb:fix/55-TaskTracer-error

Conversation

@zmyzxb
Copy link
Contributor

@zmyzxb zmyzxb commented Sep 28, 2025

Describe this PR

This PR fixes a validation error that occurred when passing a numeric task_id to the trace command. Previously, Fire parsed --task_id=15 as an integer, which was then propagated to TaskTracer as both task_id and task_name, causing Pydantic to raise a string type validation error. The fix is to cast task_id to a string when calling single_task explicitly.

Checklist for PR

Must Do

  • Write a good PR title and description, i.e. feat(agent): add pdf tool via mcp, perf: make llm client async and fix(utils): load custom config via importlib etc. CI job check-pr-title enforces Angular commit message format to PR title.
  • Run make precommit locally. CI job lint enforce ruff default format/lint rules on all new codes.
  • Run make pytest. Check test summary (located at report.html) and coverage report (located at htmlcov/index.html) on new codes.

Nice To Have

  • (Optional) Write/update tests under /tests for feat and test PR.
  • (Optional) Write/update docs under /docs for docs and ci PR.

@BinWang28 BinWang28 requested a review from Copilot September 28, 2025 10:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a validation error in the task tracing functionality when numeric task IDs are passed via command line arguments. The issue occurred because Fire parsed --task_id=15 as an integer, but the single_task function expects a string parameter.

  • Cast numeric task_id to string when calling single_task function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BinWang28 BinWang28 merged commit 734cabe into MiroMindAI:miroflow-v0.3 Sep 29, 2025
1 check passed
Zhudongsheng75 pushed a commit to open-compass/MiroFlow that referenced this pull request Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants