Revert the router's path string decoding strategy (fixes #3064) #3065
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the router’s initial decoding strategy during route path resolution to behavior similar to v2.3.7 and earlier.
#3050 fixed a decoder bug. However, because the decoder is now applied more aggressively than before, it appears to have had an unintended effect on path-segment parsing.
Additionally, since
decodeURIComponentwas being used directly withincompileTemplate(), this PR changed it to usedecodeURIComponentSafeinstead.Motivation and Context
fixes #3064
How Has This Been Tested?
npm run testAdditionally, I confirmed improved behavior in the following flems.
Types of changes
Checklist