Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality for users to send assets to their friends' Common Wallet addresses, introducing a "fetch user address" feature for Web3 transfers.
Key changes:
- Added user address fetching functionality for Web3 transfers to contacts
- Implemented UI components for fetching and displaying user addresses
- Enhanced transfer destination options to include Mixin contacts for Web3 tokens
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Added new string resources for Mixin contact transfers and address fetching |
| app/src/main/res/values-zh-rCN/strings.xml | Added Chinese translations for new string resources |
| app/src/main/res/navigation/nav_wallet.xml | Added navigation action to fetch user address fragment |
| app/src/main/java/one/mixin/android/ui/wallet/TransferContactBottomSheetDialogFragment.kt | Removed token dependency from contact selection dialog |
| app/src/main/java/one/mixin/android/ui/wallet/InputFragment.kt | Added user parameter support for Web3 transfers |
| app/src/main/java/one/mixin/android/ui/tip/wc/compose/ItemContent.kt | Added new composable for displaying user information in transfers |
| app/src/main/java/one/mixin/android/ui/home/web3/BrowserWalletBottomSheetDialogFragment.kt | Added user parameter support for wallet operations |
| app/src/main/java/one/mixin/android/ui/home/web3/BrowserPage.kt | Enhanced UI to display user information in transfer dialogs |
| app/src/main/java/one/mixin/android/ui/address/viewmodel/FetchAddressViewModel.kt | Implemented ViewModel for fetching user addresses |
| app/src/main/java/one/mixin/android/ui/address/page/TransferDestinationInputPage.kt | Added Mixin contact option for Web3 token transfers |
| app/src/main/java/one/mixin/android/ui/address/components/FetchAddressState.kt | Defined states for address fetching operations |
| app/src/main/java/one/mixin/android/ui/address/components/FetchAddressContent.kt | Created UI component for address fetching progress and error states |
| app/src/main/java/one/mixin/android/ui/address/TransferDestinationInputFragment.kt | Added Web3 contact transfer logic and navigation |
| app/src/main/java/one/mixin/android/ui/address/FetchUserAddressFragment.kt | Implemented fragment for fetching user addresses |
| app/src/main/java/one/mixin/android/api/service/RouteService.kt | Added API endpoint for fetching user addresses |
| app/src/main/java/one/mixin/android/api/response/UserAddressView.kt | Created data class for user address API response |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.