feat: Make DHCP container port configurable#401
Open
Slyrc wants to merge 1 commit intoMoJo2600:mainfrom
Open
Conversation
3 tasks
madic-creates
added a commit
to madic-creates/pihole-kubernetes
that referenced
this pull request
Jan 12, 2026
Replace hardcoded port values (53 for DNS, 67 for DHCP) with configurable values from serviceDns.port and serviceDhcp.port in deployment and service templates. Inspired by MoJo2600#401
madic-creates
added a commit
to madic-creates/pihole-kubernetes
that referenced
this pull request
Jan 12, 2026
Replace hardcoded port values (53 for DNS, 67 for DHCP) with configurable values from serviceDns.port and serviceDhcp.port in deployment and service templates. Inspired by MoJo2600#401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Make the ContainerPort of DHCP configurable
Benefits
Use alternative ports for DHCP if needed
E.g.:
https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html
Possible drawbacks
There are no
Applicable issues
N.A.
Additional information
N.A.
Checklist