[feature] infisical 시크릿 매니저 주입을 위한 코드 수정#1291
Merged
lepitaaar merged 9 commits intodevelop/befrom Mar 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning
|
| Cohort / File(s) | Summary |
|---|---|
CI/CD 워크플로우 .github/workflows/oracle_server_cd_develop.yml |
application.properties 파일 생성을 위한 쉘 명령을 echo 리다이렉션에서 여기-문서(here-document) 방식으로 변경했습니다. 다중 행 값과 리터럴 콘텐츠 보존이 가능해졌습니다. |
Java 라이브러리 import 추가 backend/src/main/java/moadong/global/config/WebConfig.java, backend/src/main/java/moadong/media/util/S3Config.java |
필수 라이브러리 import 문을 추가했습니다(java.util.Arrays, javax.annotation.PostConstruct). 로직 변경은 없습니다. |
설정 어노테이션 손상 backend/src/main/java/moadong/media/webhook/WebpMigrationService.java |
@value 어노테이션의 닫는 괄호가 누락되어 속성 주입이 실패할 수 있습니다. 런타임 오류가 발생할 가능성이 있습니다. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
- [feature] 오라클 클라우드 CI/CD 구축 #518: .github/workflows/oracle_server_cd_develop.yml 워크플로우 파일을 동시에 수정합니다.
- [setting] MOA-84 백엔드 서버 오라클 클라우드로 이전 #546: CI 워크플로우의 배포 및 애플리케이션 속성 처리 방식을 함께 변경합니다.
Suggested labels
📦 CI/CD
Suggested reviewers
- Zepelown
- seongwon030
- SeongHoonC
- oesnuj
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | PR 제목은 Infisical 시크릿 매니저 주입을 위한 코드 수정이라고 명시하고 있으나, 실제 변경사항에는 심각한 결함(WebpMigrationService의 @Value 애너테이션 손상)을 포함하고 있으며, 주요 변경 내용과 불일치합니다. |
PR 제목을 수정하여 시크릿 매니저 주입 목적의 변경사항을 정확히 반영하고, 병합 전에 WebpMigrationService의 @Value 애너테이션 손상 문제를 즉시 해결해야 합니다. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
- 📝 Generate docstrings (stacked PR)
- 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
feature/#1277-injection-secret-at-runtime-MOA-708
Tip
Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Test Results94 tests 94 ✅ 21s ⏱️ Results for commit 5a5711b. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
backend/src/main/java/moadong/media/util/S3Config.java (1)
14-15: 사용되지 않는 import입니다.
javax.annotation.PostConstruct가 import 되었지만 파일 내 어디에서도 사용되지 않습니다. 이 import를 제거해주세요.또한 참고로, Spring Boot 3.x는 Jakarta EE 10을 사용하므로
javax.annotation.PostConstruct대신jakarta.annotation.PostConstruct를 사용해야 합니다.🧹 제안된 수정
-import javax.annotation.PostConstruct; -🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/moadong/media/util/S3Config.java` around lines 14 - 15, Remove the unused import javax.annotation.PostConstruct from S3Config (it's not referenced anywhere in the S3Config class); if you actually need a PostConstruct hook in S3Config (e.g., an init method annotated with `@PostConstruct`), replace the import with jakarta.annotation.PostConstruct to match Spring Boot 3.x / Jakarta EE 10. Ensure only the correct jakarta import remains or no PostConstruct import at all if unused.backend/src/main/java/moadong/global/config/WebConfig.java (1)
3-3: 사용되지 않는 import입니다.
java.util.Arrays가 import 되었지만 파일 내 어디에서도 사용되지 않습니다. 이 import를 제거해주세요.🧹 제안된 수정
-import java.util.Arrays;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/main/java/moadong/global/config/WebConfig.java` at line 3, 파일의 불필요한 import 제거 요청: WebConfig 클래스에서 더 이상 사용되지 않는 import 문 java.util.Arrays를 제거하세요; 소스 상단의 import 라인에서 java.util.Arrays를 삭제하면 됩니다.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/oracle_server_cd_develop.yml:
- Around line 51-53: 현재 cat > application.properties <<'EOF' ... EOF 블록이 들여쓰기되어
here-document의 각 줄에 공백이 포함되므로 application.properties에 앞공백이 들어갑니다; 수정 방법은
here-document 시작/끝(즉 "cat > application.properties <<'EOF'"와 해당 "EOF")를 들여쓰기 없이
파일 맨 앞(column 0)에 위치시키거나(또는 here-doc의 내용을 왼쪽 정렬) 대신 들여쓰기 무시 기능을 사용하거나(탭만 제거되는
<<-'EOF' 사용 시 탭으로 들여쓸 경우) 더 안전하게는 secrets 내용을 직접 덤프하는 방식으로 바꿔서(예: printf '%s\n'
"${{ secrets.APPLICATION_PROD_DEV }}" > application.properties 또는 echo "${{
secrets.APPLICATION_PROD_DEV }}" > application.properties) 앞공백이 들어가지 않게 만드세요.
In `@backend/src/main/java/moadong/media/webhook/WebpMigrationService.java`:
- Around line 34-35: The `@Value` annotation in WebpMigrationService for the
viewEndpoint field is missing the closing curly brace; update the `@Value` string
for the viewEndpoint property (the line with
`@Value`("${cloud.aws.s3.view-endpoint") and the private String viewEndpoint;) to
include the missing '}' so it becomes a valid Spring property placeholder (e.g.,
`@Value`("${cloud.aws.s3.view-endpoint}")).
---
Nitpick comments:
In `@backend/src/main/java/moadong/global/config/WebConfig.java`:
- Line 3: 파일의 불필요한 import 제거 요청: WebConfig 클래스에서 더 이상 사용되지 않는 import 문
java.util.Arrays를 제거하세요; 소스 상단의 import 라인에서 java.util.Arrays를 삭제하면 됩니다.
In `@backend/src/main/java/moadong/media/util/S3Config.java`:
- Around line 14-15: Remove the unused import javax.annotation.PostConstruct
from S3Config (it's not referenced anywhere in the S3Config class); if you
actually need a PostConstruct hook in S3Config (e.g., an init method annotated
with `@PostConstruct`), replace the import with jakarta.annotation.PostConstruct
to match Spring Boot 3.x / Jakarta EE 10. Ensure only the correct jakarta import
remains or no PostConstruct import at all if unused.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.github/workflows/oracle_server_cd_develop.ymlbackend/src/main/java/moadong/global/config/WebConfig.javabackend/src/main/java/moadong/media/util/S3Config.javabackend/src/main/java/moadong/media/webhook/WebpMigrationService.java
backend/src/main/java/moadong/media/webhook/WebpMigrationService.java
Outdated
Show resolved
Hide resolved
suhyun113
approved these changes
Mar 3, 2026
Collaborator
suhyun113
left a comment
suhyun113
left a comment
There was a problem hiding this comment.
LGTM~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
infisical secret manager 주입을 테스트 했읍니다..
중점적으로 리뷰받고 싶은 부분(선택)
논의하고 싶은 부분(선택)
🫡 참고사항
Summary by CodeRabbit
릴리스 노트
버그 수정
기타