Skip to content

Fixing bug executing setup.sh script in python venv #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ByteSnipers wants to merge 3 commits into from
Closed

Fixing bug executing setup.sh script in python venv #2475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbb1a06
Fixing bug executing setup.sh script in python venv
ByteSnipers Dec 18, 2024
bc92806
Merge branch 'master' into patch-1
ByteSnipers Dec 18, 2024
389a949
Merge branch 'master' into patch-1
ByteSnipers Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,17 @@ if [[ "$py_major" -ne 3 || "$py_minor" -lt 10 || "$py_minor" -gt 12 ]]; then
fi
echo "[INSTALL] Found Python ${python_version}"

# Check and upgrade pip
if python3 -m pip -V &>/dev/null; then
# Pip Check and Upgrade
python3 -m pip -V
Copy link
Member

@ajinabraham ajinabraham Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be replaced with pip_location ?

if [ $? -eq 0 ]; then
echo '[INSTALL] Found pip'
upgrade_cmd="python3 -m pip install --no-cache-dir --upgrade pip"
[[ "$(uname)" != "Darwin" ]] && upgrade_cmd+=" --user"
eval $upgrade_cmd
# check if python is running in venv. The location for venv should be differ from /usr/lib/python3.xx
pip_location=`python3 -m pip -V`
if [[ $unamestr == 'Darwin' || "$pip_location" != "/usr/lib/python"* ]]; then
python3 -m pip install --no-cache-dir --upgrade pip
else
python3 -m pip install --no-cache-dir --upgrade pip --user
fi
else
echo '[ERROR] python3-pip not installed'
exit 1
Expand Down
Loading