Fix false positives caused in Android manifest analysis#2481
Closed
nick-lupien wants to merge 2 commits intoMobSF:masterfrom
Closed
Fix false positives caused in Android manifest analysis#2481nick-lupien wants to merge 2 commits intoMobSF:masterfrom
nick-lupien wants to merge 2 commits intoMobSF:masterfrom
Conversation
Member
|
Thanks for the PR. I will review this and get back. |
Member
|
Simplified the logic a bit to automatically handle this without requiring a redirect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Problem:
assetlinks.jsonredirect from http->https. In these instances, high-severity findings would appear in the Manifest Analysis section suggesting that the URLs were configured incorrectly, when in fact the 301 redirect is a valid configuration.allow_redirectstoTruein therequests.get, but this was removed in (f22c584) specifically to mitigate GHSA-m435-9v6r-v5f6.Solution:
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)Additional Comments (if any)