Closed
Conversation
added 3 commits
February 6, 2025 17:27
ajinabraham
reviewed
Mar 23, 2025
| elif vrole or settings.IDP_MOBSF_DEFAULT_GROUP == 'Viewer': | ||
| logger.info('User assigned to %s group.', VIEWER_GROUP) | ||
| return VIEWER_GROUP | ||
| logger.warning('User does not have an authorized SSO group.') |
Member
There was a problem hiding this comment.
Is there a reason to support this? We do not want to over complicate SSO roles. MobSF only has two role privileges a read-only default role for everyone and a read-write maintainer role for maintainer group.
| email = attributes['email'][0] | ||
| role = get_user_role(attributes['role']) | ||
| if not role: | ||
| raise Exception( |
Member
There was a problem hiding this comment.
Users/Groups that doesn't need MobSF access shouldn't be added in the MobSF SAML app.
https://mobsf.github.io/docs/#/sso
Member
|
Closing this as the PR is not active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Pull Request
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)Additional Comments (if any)