Add CI check for Python scripts#2163
Merged
DocMoebiuz merged 8 commits intoMobiFlight:mainfrom May 25, 2025
Merged
Conversation
Contributor
|
Thanks a lot! Every help is appreciated. |
Contributor
|
Python script adjustments seem fine. CI I cannot judge. From my point of view ready to be merged. |
DocMoebiuz
requested changes
May 18, 2025
Collaborator
DocMoebiuz
left a comment
DocMoebiuz
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Please rename scripts.yml to python-script-checks.yml to make it clear that they are focusing on the python scripts
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
Contributor
Author
|
@DocMoebiuz Friendly reminder that this is ready for re-review |
DocMoebiuz
approved these changes
May 25, 2025
DocMoebiuz
added
the
development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #2162
Add CI check for Python scripts that verifies that the scripts work with supported Python versions and that there are no import issues.
Example failure when running with Python 3.10:
https://github.com/Nezz/MobiFlight-Connector/actions/runs/15087553498/job/42412022488
This revealed a couple of issues in the existing scripts that I fixed.