ControllerBindings update when Profiles change#2743
Merged
DocMoebiuz merged 5 commits intomainfrom Feb 23, 2026
Merged
Conversation
…frontend if they have changed.
|
Build for this pull request: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates controller binding metadata when project configs change, addressing stale controller lists on the frontend (Issue #2715) by emitting a dedicated backend-to-frontend update message and wiring it into the frontend store.
Changes:
- Backend: analyze controller bindings on config changes and publish an outgoing bindings-update message.
- Frontend: add a new app-message type/key and update the project store when bindings-update messages arrive.
- Tests/build: add a unit test and include the new outgoing message DTO in the csproj.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/types/messages.d.ts | Adds a new app message key/payload type for controller bindings updates. |
| frontend/src/stores/projectStore.ts | Adds a store action to update project.ControllerBindings in Zustand state. |
| frontend/src/lib/hooks/useBackendStateAppMessages.ts | Subscribes to the new controller bindings update message and applies it to the project store. |
| UI/MainForm.cs | Triggers controller bindings re-analysis on config changes and publishes an update message when changed. |
| MobiFlightUnitTests/UI/MainFormTests.cs | Adds a unit test intended to verify bindings update behavior on config changes. |
| MobiFlightConnector.csproj | Includes the new outgoing message DTO in compilation. |
| MobiFlight/BrowserMessages/Outgoing/ControllerBindingUpdate.cs | Adds the outgoing message DTO carrying updated bindings. |
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
DocMoebiuz
added
bug_beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2715