Fix exception in OutputConfig Input Actions#2746
Merged
DocMoebiuz merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
|
Build for this pull request: |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a NullReferenceException that occurred when executing OutputConfig items with InputActions when the Controller is null. The issue arose from improper null handling in serial number validation.
Changes:
- Replaced unsafe
serial.IndexOf("SN") != 0check with null-safeSerialNumber.IsArcazeSerial(serial)method - Added comprehensive unit test to prevent regression of this bug
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MobiFlight/Execution/ConfigItemExecutor.cs | Fixed NullReferenceException by using null-safe SerialNumber.IsArcazeSerial() method instead of direct IndexOf() call |
| MobiFlightUnitTests/MobiFlight/Execution/ConfigItemExecutorTests.cs | Added test case to verify no exception is thrown when Controller is null with InputAction DeviceType |
|
Build for this pull request: |
DocMoebiuz
added
the
bug_beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2745