-
Notifications
You must be signed in to change notification settings - Fork 214
Target WasmJS #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target WasmJS #646
Conversation
amrfarid140
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there 👋🏽 I like reading OSS PRs for projects I am using. I spotted one tiny feedback but please feel free to ignore as I don't have a good level of context on this work.
| when (this) { | ||
| is StoreReadResponse.Error.Exception -> throw error | ||
| is StoreReadResponse.Error.Message -> throw RuntimeException(message) | ||
| fun StoreReadResponse.Error.doThrow(): Throwable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: doThrow name isn't applicable anymore here.
|
Nice, would be cool if this got merged :D |
52263f3 to
d88d66e
Compare
Signed-off-by: Matt Ramotar <[email protected]>
d88d66e to
a9e4dc6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 38 38
Lines 920 920
Branches 169 168 -1
=======================================
Hits 689 689
Misses 144 144
Partials 87 87
|
Signed-off-by: Matt Ramotar <[email protected]>
Signed-off-by: Matt Ramotar <[email protected]>
Closes #644
Test Plan
All existing unit tests are passing
Additional Notes:
https://youtrack.jetbrains.com/issue/KT-69534/WasmJs-compilation-fails-with-anonymous-objects-and-exception-throwing-in-when-expressions. Changes to compile:
DefaultConverter(seeRealStoreBuilder.kt)StoreReadResponse.Error.doThrow()to returnThrowable(seeStoreReadResponse.kt)Updated: