-
Notifications
You must be signed in to change notification settings - Fork 214
Fix Eager Conflict Resolution Deadlock and Improve Mutable Store Code Quality #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matt Ramotar <[email protected]>
Signed-off-by: Matt Ramotar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 75.43% 79.12% +3.69%
==========================================
Files 38 40 +2
Lines 920 939 +19
Branches 168 169 +1
==========================================
+ Hits 694 743 +49
+ Misses 142 120 -22
+ Partials 84 76 -8
|
|
nit, can we try to keep the prs single purpose for easier review <3 |
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/Logger.kt
Show resolved
Hide resolved
| * @param message The debug message to log. | ||
| */ | ||
| fun debug(message: String) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not currently using info and this component isn't currently being exposed to the consumer. There's an open request to improve logging #638. My plan is to replace this then with logging hooks delegated to the user
digitalbuddha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding tests <3
Closes #667
Closes #578
This PR is fixing a deadlock in eager conflict resolution. To improve code quality, this PR also: