Fix flat structure detection by checking against all the subSections
#229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested review from
CognitiveDisson,
aleksandergrzyb,
ecamacho and
polac24
as code owners
Collaborator
|
Looks like a duplicate of #227 |
aleksandergrzyb
approved these changes
May 28, 2025
Collaborator
Author
|
How is in charge of merging these PRs? |
Collaborator
|
@pepicrft I've been wondering the same, it's pretty sad to see this project not being maintained that well 😢 |
aleksandergrzyb
merged commit 565116b
into
MobileNativeFoundation:master
4 checks passed
Collaborator
Collaborator
|
I'm pretty sure you can make us both maintainer, yes! |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the report I was getting did not group the targets of the activity log. The check against the first 15 elements that's hardcoded in the project turns out to be too limiting. After I removed it, the grouping worked as expected.
What's the reason why the limit of 15 was added?