-
Notifications
You must be signed in to change notification settings - Fork 113
Add support for App Language and App Region scheme test action options
#3105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for App Language and App Region scheme test action options
#3105
Conversation
App Language and App Region scheme test action options
tools/generators/xcschemes/src/Generator/AutogenerationConfigArguments.swift
Outdated
Show resolved
Hide resolved
62b5468 to
8601d94
Compare
…in the TestAction tag in xcscheme files Signed-off-by: longsview <[email protected]>
…me generation support Signed-off-by: longsview <[email protected]>
…sed (MobileNativeFoundation#3104) Signed-off-by: Brentley Jones <[email protected]> Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
…rguments.swift Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Co-authored-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
8601d94 to
6a85ca0
Compare
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
Signed-off-by: longsview <[email protected]>
| diagnostics = None, | ||
| env = "inherit", | ||
| env_include_defaults = True, | ||
| test_options = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for message on the PR instead of creating issue, Im getting this failure on 2.9.0, and suspecting this is the cause (not this line specifically)
Error in add_all: expected value of type 'sequence or depset' for values, got 'NoneType'
File "/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_xcodeproj~2.9.0/xcodeproj/internal/xcodeproj_incremental_rule.bzl", line 708, column 53, in _xcodeproj_incremental_impl
(xcschemes, xcschememanagement) = _write_schemes(
File "/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_xcodeproj~2.9.0/xcodeproj/internal/xcodeproj_incremental_rule.bzl", line 540, column 67, in _write_schemes
autogeneration_config_file = _write_autogeneration_config_file(
File "/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_xcodeproj~2.9.0/xcodeproj/internal/xcodeproj_incremental_rule.bzl", line 222, column 17, in _write_autogeneration_config_file
args.add_all(config.get("test_options"))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…tions (MobileNativeFoundation#3105) Added support for `language` and `region`. This can be done through the auto scheme generation using `autogeneration_config`: ``` xcodeproj( … scheme_autogeneration_config = xcschemes.autogeneration_config( test = xcschemes.autogeneration.test( test_options = xcschemes.test_options( app_language = "en", app_region = "US", ) ) ), … ) ``` or by providing an options struct in a custom scheme: ``` xcschemes.scheme( … test = xcschemes.test( … test_options = xcschemes.test_options( app_language = "en", app_region = "US", ), … ), … ) ``` These configurations will add the appropriate tags to the `<TestAction>` tag. Corresponding settings in Xcode: <img width="500" src="https://github.com/user-attachments/assets/9bef3d96-99bf-4b20-92a0-2b8548766783"> --------- Signed-off-by: longsview <[email protected]> Signed-off-by: Brentley Jones <[email protected]> Signed-off-by: Nicholas Long <[email protected]> Co-authored-by: Brentley Jones <[email protected]> Co-authored-by: Chuck Grindel <[email protected]> Signed-off-by: Karim Alweheshy <[email protected]>
Added support for
languageandregion. This can be done through the auto scheme generation usingautogeneration_config:or by providing an options struct in a custom scheme:
These configurations will add the appropriate tags to the
<TestAction>tag.Corresponding settings in Xcode:
