Add ExtensionKit support #3109
Merged
Add ExtensionKit support #3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congt
force-pushed
the
cshi/fix-extensionkit
branch
2 times, most recently
from
5a4fcb9 to
e9fe324
Compare
luispadron
reviewed
Nov 15, 2024
tools/extension_point_identifiers_parser/extension_point_identifiers_parser.py
Show resolved
Hide resolved
congt
force-pushed
the
cshi/fix-extensionkit
branch
from
e9fe324 to
bf920d1
Compare
luispadron
approved these changes
Nov 16, 2024
congt
force-pushed
the
cshi/fix-extensionkit
branch
from
bf920d1 to
018de94
Compare
brentleyjones
approved these changes
Nov 19, 2024
tools/extension_point_identifiers_parser/extension_point_identifiers_parser.py
Outdated
Show resolved
Hide resolved
ExtensionKit extensions uses EXAppExtensionAttributes in its info.plist. extension_point_identifiers_parser.py didn't support that so that it fails to find the ExtensionKit extensions. Also adds an ExtensionKit extension to the example iOSAPP. Signed-off-by: Cong Shi <[email protected]>
congt
force-pushed
the
cshi/fix-extensionkit
branch
from
018de94 to
7e0d0b7
Compare
brentleyjones
approved these changes
Nov 19, 2024
Contributor
Author
|
Friendly ping for check runs again. The merge was blocked because the branch was out of date with the base branch. |
brentleyjones
approved these changes
Nov 26, 2024
brentleyjones
merged commit 53036fa
into
MobileNativeFoundation:main
15 of 16 checks passed
karim-alweheshy
pushed a commit
to karim-alweheshy/rules_xcodeproj
that referenced
this pull request
Mar 6, 2025
ExtensionKit extensions uses `EXAppExtensionAttributes` in its `Info.plist`. `extension_point_identifiers_parser.py` didn't support that so that it fails to find the ExtensionKit extensions. Also adds an ExtensionKit extension to the example iOSAPP. Signed-off-by: Cong Shi <[email protected]> Signed-off-by: Karim Alweheshy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionKit extensions uses
EXAppExtensionAttributesin itsInfo.plist.extension_point_identifiers_parser.pydidn't support that so that it fails to find the ExtensionKit extensions.Also adds an ExtensionKit extension to the example iOSAPP.