wip: Support StoreKit Configuration setting in xcscheme Run action #3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
closing in favor of #3185 |
aaronsky
deleted the
aaronsky/3130-support-storekit-configuration-run-action
branch
brentleyjones
pushed a commit
that referenced
this pull request
Nov 19, 2025
Fixes #3130. Redoes #3182 (and potentially fixes unresolved comments on #3185). The StoreKit Testing configuration file has a peculiar requirement that has no precedent in the rules. The file's path in the scheme must be relative to the `xcshareddata/xcschemes` directory the scheme is under, not the scheme itself (so one level shallower than you'd expect). Making the path relative to the project fails, and making it absolute crashes Xcode. A prior iteration of this PR attempted to relativize the path in Starlark, but exposed some safety shortcomings. In knowing the absolute path of both the scheme directory and the configuration file, doing this work in the generator gives us slightly improved safety guarantees at the cost of performance. To this author, there is too much ambiguity between the paths of either location without this information, since the files can potentially exist in independent file trees under a workspace. --------- Signed-off-by: Aaron Sky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3130